Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #868 +/- ##
==========================================
- Coverage 44.30% 44.16% -0.14%
==========================================
Files 313 316 +3
Lines 6230 6281 +51
Branches 989 1000 +11
==========================================
+ Hits 2760 2774 +14
- Misses 3449 3486 +37
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eantones
force-pushed
the
16.0-add-product_catalog_sale_rental
branch
2 times, most recently
from
0ba8009 to
acbac0e
Compare
Bridge between product_catalog_sale and sale_rental so that products added from the catalog on a rental order create proper rental lines with rental_type, rental_qty, start/end dates and the correct product_uom_qty (rental_qty × number_of_days). The start_date and end_date fields on sale.order.line are redefined with readonly=False to allow programmatic writes during create(), working around a circular dependency issue in the upstream sale_start_end_dates computes that prevents dates from being auto-filled when lines are created outside the form view.
eantones
force-pushed
the
16.0-add-product_catalog_sale_rental
branch
from
acbac0e to
65210b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product_catalog_saleandsale_rentalso that products added from the catalog create proper rental lines withrental_type,rental_qty, dates and computedproduct_uom_qtyreadonly=Falsetostart_date/end_dateonsale.order.lineto work around a circular dependency issue insale_start_end_datescomputes during programmaticcreate()product_catalog,product_catalog_sale)Test plan
product_catalog_saleandsale_rentalrented_product_idrental_type,rental_qty, dates andproduct_uom_qty = qty × daysrental_qtyandproduct_uom_qtyupdate